Skip to content

logger enhancement #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tavallaie merged 5 commits into from
Dec 21, 2025
Merged

logger enhancement #10

tavallaie merged 5 commits into from
Dec 21, 2025

Conversation

@tavallaie
Copy link
Collaborator

@tavallaie tavallaie commented Oct 20, 2025

I tried to solve #8, but I didn't add unittest for logger. Also I add loguru as an optional dependency with fall back mechanism.

@tavallaie
Copy link
Collaborator Author

tavallaie commented Oct 20, 2025

intersting, I found some bugs that bypass the tests :D

@tavallaie
Copy link
Collaborator Author

tavallaie commented Oct 20, 2025

I don't know if it is a bug or not.
@ChuckHend why do we have this in our tests and still it is passing the tests? I don't have a clue here

..2025-10-20 16:13:48,496 - pgmq.async_queue - ERROR - Transaction failed: transactional_create_queue - transactional_create_queue() got an unexpected keyword argument 'conn' | event=transaction_error | function=transactional_create_queue | error_type=TypeError | error_message=transactional_create_queue() got an unexpected keyword argument 'conn' | conn_id=139933109644304
.2025-10-20 16:13:48,549 - pgmq.async_queue - ERROR - Transaction failed: transactional_operation - transactional_operation() got an unexpected keyword argument 'conn' | event=transaction_error | function=transactional_operation | error_type=TypeError | error_message=transactional_operation() got an unexpected keyword argument 'conn' | conn_id=139933109896288

@ChuckHend
Copy link
Contributor

ChuckHend commented Oct 21, 2025

@tavallaie , I see that too. Maybe something broke when we ported the CI over?

@tavallaie
Copy link
Collaborator Author

tavallaie commented Oct 21, 2025 •
edited
Loading

@ChuckHend, I didn't see it in last action before I adding logger to the decorator so I will revert it to find if it is related to my changes or not.

@tavallaie
Copy link
Collaborator Author

tavallaie commented Oct 21, 2025

OK, my decorator.py changes can bypass the tests, so I’ll go with Plan B.
I’ll fix some minor styling issues on the main branch and publish a new version on PyPI.
Then I’ll work on more unit tests and come back to this enhancement later.

@tavallaie tavallaie mentioned this pull request Oct 21, 2025
Open
@tavallaie tavallaie marked this pull request as draft December 15, 2025 07:58
@tavallaie tavallaie marked this pull request as ready for review December 20, 2025 16:26
@tavallaie tavallaie requested a review from ChuckHend December 20, 2025 16:26
@tavallaie tavallaie merged commit 2ffbcac into pgmq:main Dec 21, 2025
3 checks passed
@tavallaie tavallaie deleted the 8-improve-pgmq-logging-setup branch December 21, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChuckHend ChuckHend ChuckHend approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tavallaie @ChuckHend